fix: restore v5 rendering parity for video-message and hero#150
Merged
Conversation
The v2.0.1 cleanup removed the empty-string gutter argument, which under v6 lets the schema default (4) apply and adds a vertical 1.5rem gap between stacked messages. An explicit 0 passes validation (range 0-5) while the partial's with-guard skips the g-* class, reproducing the v1 rendering exactly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The horizontal image-column math relied on the argument engine filling heading.width with the global default (8). That nested default is suppressed at the type level (section titles and images span their columns as in v5), so an omitted heading.width would reach sub as nil and fail the build. A local fallback keeps the documented behavior regardless of engine fills. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual-review fixes from the gethinode.com v6-generation validation session:
🤖 Generated with Claude Code